Re: build remaining Flex files standalone

From: Andres Freund <andres(at)anarazel(dot)de>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: build remaining Flex files standalone
Date: 2022-09-02 18:29:02
Message-ID: 20220902182902.vsjjwnxd3vietvup@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi John,

Are you planning to press ahead with these?

> Subject: [PATCH v4 01/11] Preparatory refactoring for compiling guc-file.c
> standalone
> Subject: [PATCH v4 02/11] Move private declarations shared between guc.c and
> guc-file.l to new header
> Subject: [PATCH v4 03/11] Build guc-file.c standalone

01-03 are a bit more complicated, but still look not far off. There's a FIXME
about failing headercheck.

> Subject: [PATCH v4 04/11] Build bootscanner.c standalone
> Subject: [PATCH v4 05/11] Build repl_scanner.c standalone
> Subject: [PATCH v4 06/11] Build syncrep_scanner.c standalone
> Subject: [PATCH v4 07/11] Build specscanner.c standalone
> Subject: [PATCH v4 08/11] Build exprscan.c standalone

LGTM

> Subject: [PATCH v4 09/11] Build cubescan.c standalone
>
> Pass scanbuflen as a parameter to yyparse rather than
> resorting to a global variable.

Nice.

> Subject: [PATCH v4 10/11] Build segscan.c standalone
> Subject: [PATCH v4 11/11] Build jsonpath_scan.c standalone

LGTM.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-09-02 18:31:57 Re: minimum perl version
Previous Message Andres Freund 2022-09-02 18:15:53 minimum perl version