| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Functions 'is_publishable_class' and 'is_publishable_relation' should stay together. |
| Date: | 2022-07-29 09:59:00 |
| Message-ID: | 20220729095900.kemsantarx4klz5r@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Jul-29, Peter Smith wrote:
> On Fri, Jul 29, 2022 at 7:36 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >
> > I don't object to doing this, but I think these two functions should
> > stay together nonetheless.
>
> If you believe there is still a problem after applying the patch
> please explicitly name what function(s) you think should be moved.
Well, I checked the commit and the functions I was talking about look OK
now. However, looking again, pg_relation_is_publishable is in the wrong
place (should be right below is_publishable_relaton), and I wonder why
aren't get_publication_oid and get_publication_name in lsyscache.c.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-07-29 10:17:44 | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |
| Previous Message | Peter Smith | 2022-07-29 09:51:07 | Re: Functions 'is_publishable_class' and 'is_publishable_relation' should stay together. |