Re: make -C libpq check fails obscurely if tap tests are disabled

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: make -C libpq check fails obscurely if tap tests are disabled
Date: 2022-07-21 08:53:48
Message-ID: 20220721085348.dqnhfcqs6kyga2ym@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Jul-20, Andrew Dunstan wrote:

> On 2022-07-20 We 13:23, Justin Pryzby wrote:
> > PATH=... && @echo "TAP tests not enabled. Try configuring with --enable-tap-tests"
> > /bin/sh: 1: @echo: not found
> >
> > make is telling the shell to run "@echo" , rather than running "echo" silently.

> Yeah. It's a bit ugly but I think the attached would fix it.

Here's a different take. Just assign the variable separately.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"No renuncies a nada. No te aferres a nada."

Attachment Content-Type Size
0001-Fix-interfaces-libpq-makefile.patch text/x-diff 982 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-07-21 09:02:59 Re: Is it correct to say, "invalid data in file \"%s\"", BACKUP_LABEL_FILE in do_pg_backup_stop?
Previous Message Kyotaro Horiguchi 2022-07-21 08:48:02 Re: i.e. and e.g.