| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | masao(dot)fujii(at)oss(dot)nttdata(dot)com |
| Cc: | sawada(dot)mshk(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve description of XLOG_RUNNING_XACTS |
| Date: | 2022-07-21 07:29:44 |
| Message-ID: | 20220721.162944.256232039087599002.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Thu, 21 Jul 2022 11:21:09 +0900, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
>
>
> On 2022/07/21 10:13, Masahiko Sawada wrote:
> > Hi,
> > I realized that standby_desc_running_xacts() in standbydesc.c doesn't
> > describe subtransaction XIDs. I've attached the patch to improve the
> > description.
>
> +1
>
> The patch looks good to me.
The subxids can reach TOTAL_MAX_CACHED_SUBXIDS =
PGPROC_MAX_CACHED_SUBXIDS(=64) * PROCARRAY_MAXPROCS. xact_desc_commit
also shows subtransactions but they are at maximum 64. I feel like
-0.3 if there's no obvious advantage showing them.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-07-21 07:34:05 | Re: Schema variables - new implementation for Postgres 15 |
| Previous Message | Erik Rijkers | 2022-07-21 07:09:47 | Re: Schema variables - new implementation for Postgres 15 |