| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Färber, Franz-Josef (StMUK) <Franz-Josef(dot)Faerber(at)stmuk(dot)bayern(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Extension pg_trgm, permissions and pg_dump order |
| Date: | 2022-06-21 17:56:16 |
| Message-ID: | 20220621175616.GA93985@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-general |
On Wed, Jun 15, 2022 at 10:42:18PM -0700, Noah Misch wrote:
> -REGRESS = citext citext_utf8
> +REGRESS = create_index_acl citext citext_utf8
It's a little unfortunate that these tests are located within the citext
module, but I can't claim to have a better idea.
> + * Identify the opclass to use. Use of ddl_userid is necessary due to
> + * ACL checks therein. This is safe despite opclasses containing
> + * opaque expressions (specifically, functions), because only
> + * superusers can define opclasses.
It's not clear to me why the fact that only superusers can define opclasses
makes this safe.
Overall, the patch seems reasonable to me.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2022-06-21 18:34:05 | Re: BUG #17522: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL test fails on OpenBSD 7.1 |
| Previous Message | Amit Kapila | 2022-06-21 13:38:36 | Re: BUG #17524: Increase in WAL size due to logical replication with publication contain a table with low activity. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2022-06-22 03:37:04 | Re: Extension pg_trgm, permissions and pg_dump order |
| Previous Message | Adrian Klaver | 2022-06-21 14:51:53 | Re: How to use 32 bit ODBC driver |