Re: convert libpq uri-regress tests to tap test

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: convert libpq uri-regress tests to tap test
Date: 2022-02-26 01:52:29
Message-ID: 20220226015229.c4ofvhbsd3ej6weo@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-02-25 09:56:47 -0800, Andres Freund wrote:
> On 2022-02-24 08:46:23 -0800, Andres Freund wrote:
> > I'm mildly inclined to only do 0001 and 0002 for now. We'd not loose msvc
> > coverage, because it already doesn't build the test. Once we've ironed that
> > stuff out, we could do 0003?
>
> From what I can see in the buildfarm client, we'd not loose (nor gain) any
> buildfarm coverage either. It doesn't run the test today.

Attached are rebased patches. I polished 0001, the regress.pl -> 001_uri.pl
conversion some more (although some of perltidy's changes aren't clearly an
improvement).

I'd like to commit 0001 and 0002 soon, unless somebody sees a reason not to?

Greetings,

Andres Freund

Attachment Content-Type Size
v3-0001-Convert-src-interfaces-libpq-test-to-a-tap-test.patch text/x-diff 18.7 KB
v3-0002-Run-tap-tests-in-src-interfaces-libpq.patch text/x-diff 3.3 KB
v3-0003-Move-libpq_pipeline-test-into-src-interfaces-libp.patch text/x-diff 7.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2022-02-26 01:52:48 Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations
Previous Message Justin Pryzby 2022-02-26 01:10:10 Re: set TESTDIR from perl rather than Makefile