| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: bailing out in tap tests nearly always a bad idea |
| Date: | 2022-02-23 16:40:10 |
| Message-ID: | 20220223164010.kntbogadur6szxt5@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-02-23 08:43:38 -0500, Andrew Dunstan wrote:
>
> On 2/22/22 15:54, Andres Freund wrote:
> > On 2022-02-22 15:10:30 -0500, Andrew Dunstan wrote:
> >> I'll be surprised if we can't come up with something cleaner than that.
> > Suggestions?
>
>
> If we just have the sig handler actions as:
>
> diag("died: $_[0]");
> done_testing();
>
> we get:
>
> ok 1 - foo
> # died: blorb at tst/tst.pl line 5.
> 1..1
> # Looks like your test exited with 25 just after 1.
>
>
> Would that work?
Well, the if condition I had is needed, afaics. Otherwise we break eval() and
/ or risk crashing on syntax errors. If you're just talking about diag() vs
ok(0, ...), I'm good with that.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-02-23 16:47:20 | Re: Frontend error logging style |
| Previous Message | Ashutosh Sharma | 2022-02-23 16:16:28 | Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs) |