From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
---|---|
To: | Joe Conway <mail(at)joeconway(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH v2] use has_privs_for_role for predefined roles |
Date: | 2022-02-10 19:28:29 |
Message-ID: | 20220210192829.GB1684442@nathanxps13 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Feb 09, 2022 at 04:39:11PM -0500, Joe Conway wrote:
> On 2/9/22 13:13, Nathan Bossart wrote:
>> I do wonder if users find the differences between predefined roles and role
>> attributes confusing. INHERIT doesn't govern role attributes, but it will
>> govern predefined roles when this patch is applied. Maybe the role
>> attribute system should eventually be deprecated in favor of using
>> predefined roles for everything. Or perhaps the predefined roles should be
>> converted to role attributes.
>
> Yep, I was suggesting that the latter would have been preferable to me while
> Robert seemed to prefer the former. Honestly I could be happy with either of
> those solutions, but as I alluded to that is probably a discussion for the
> next development cycle since I don't see us doing that big a change in this
> one.
I agree. I still think Joshua's proposed patch is a worthwhile improvement
for v15.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2022-02-10 19:33:15 | Re: Race condition in TransactionIdIsInProgress |
Previous Message | Nathan Bossart | 2022-02-10 19:26:12 | Re: make MaxBackends available in _PG_init |