Re: pgsql: Check that we have a working tar before trying to use it

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Date: 2021-12-09 06:49:28
Message-ID: 20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2021-12-09 14:47:39 +0900, Michael Paquier wrote:
> On Wed, Dec 08, 2021 at 07:08:56PM -0800, Andres Freund wrote:
> > On 2021-12-08 18:46:04 -0800, Andres Freund wrote:
> >> On 2021-12-08 21:18:54 -0500, Tom Lane wrote:
> >> It's not stable, but afaict all the "instability" can be handled by relying on
> >> a system-set environment variable... Referencing it as
> >> $ENV{SYSTEMROOT}/system32/tar.exe ought to work? I'll test that approach via
> >> CI, but of course that won't verify that it works in all kinds of odd
> >> installations.
> >
> > That worked: https://cirrus-ci.com/task/6302355785252864
> > https://github.com/anarazel/postgres/commit/49cf19f160080353da391f177a7d8c28218023bb
>
> Well, I am afraid that this is not a completely stable path. That
> would not work here, for one.

Could you expand on why it doesn't work? As far as I can tell tar is shipped
with windows these days, and %SYSTEMROOT%/system32/tar.exe should point to
that tar?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-12-09 07:10:39 Re: pgsql: Check that we have a working tar before trying to use it
Previous Message Michael Paquier 2021-12-09 06:21:05 pgsql: Fix some typos with {a,an}