Re: pgsql: Check that we have a working tar before trying to use it

Hi,

On 2021-12-08 18:46:04 -0800, Andres Freund wrote:
> On 2021-12-08 21:18:54 -0500, Tom Lane wrote:
> > Andres Freund <andres(at)anarazel(dot)de> writes:
> > > Git appears to install itself in front of c:\windows\system32 in PATH (which
> > > contains the system tar). Which I think means that after edc2332550 this will
> > > have to be manually addressed by most people running tests on windows
> > > manually? That doesn't seem great :(
> >
> > Can we make the default be the system tar (ie a full path, not
> > just "tar")? I have no idea if that's a stable thing on Windows ...
>
> It's not stable, but afaict all the "instability" can be handled by relying on
> a system-set environment variable... Referencing it as
> $ENV{SYSTEMROOT}/system32/tar.exe ought to work? I'll test that approach via
> CI, but of course that won't verify that it works in all kinds of odd
> installations.

That worked: https://cirrus-ci.com/task/6302355785252864
https://github.com/anarazel/postgres/commit/49cf19f160080353da391f177a7d8c28218023bb

[03:01:52.451] t/010_pg_basebackup.pl ... ok
[03:02:09.737] t/020_pg_receivewal.pl ... ok
[03:02:11.837] t/030_pg_recvlogical.pl .. ok
[03:02:11.848] Result: PASS

From the commit (which also removes a previous way to address this, ignore
that):

# For tar default to the tar shipped with windows. It's common to have git's
# tar in PATH, and that doesn't handle drive letters.

I guess the comma before and is wrong? But somehow it sounds odd to me to not
have it. I guess it should be a which?

Greetings,

Andres Freund