| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. |
| Date: | 2021-11-06 22:41:45 |
| Message-ID: | 20211106224145.ujges4hs7tyqglp7@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi,
On 2021-11-06 18:24:21 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
>
> I happened to notice from grepping that
> src/backend/port/win32/crashdump.c has its own
>
> #define WIN32_LEAN_AND_MEAN
>
> Can't we remove that now? (I kind of wonder what good it did at all,
> considering postgres.h has already pulled in <windows.h>.)
Yea, it seems pointless.
There's a semi-related weirdness: Several src/port/ files include <windows.h>
themselves (I guess that could be seen as prep for dropping windows.h from
win32_port.h).
Unless you're already done with that by the time I git pull, I'm gonna remove
that redundant WIN32_LEAN_AND_MEAN.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-11-06 22:47:19 | pgsql: windows: Remove use of WIN32_LEAN_AND_MEAN from crashdump.c. |
| Previous Message | Andres Freund | 2021-11-06 22:34:20 | Re: pgsql: pgcrypto: Remove non-OpenSSL support |