| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: pgcrypto: Remove non-OpenSSL support |
| Date: | 2021-11-06 22:34:20 |
| Message-ID: | 20211106223420.xfnbfiwhcxhfwiam@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi,
On 2021-11-06 18:07:09 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > This appears to have broken msvc pgcrypto being tested with msvc. I think
> > that's because pgcrypto is still listed in the "base" @contrib_excludes and
> > thus just isn't getting built anymore, now that the special-case build rule is
> > gone?
>
> I came to the same conclusion and pushed that change. We'll soon
> see whether it's sufficient.
It was sufficient. The tests are still running, but the pgcrypto test just
passed (see contribcheck_test):
https://cirrus-ci.com/task/6128369478664192
vs previous run before rebasing:
https://cirrus-ci.com/task/5856750176829440
This is the meson branch, but testing the src/tools/msvc style build.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-11-06 22:41:45 | Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. |
| Previous Message | Tom Lane | 2021-11-06 22:24:21 | Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. |