| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Devrim Gündüz <devrim(at)gunduz(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, philip(dot)dub(at)microsoft(dot)com, jelte(dot)fennema(at)microsoft(dot)com |
| Subject: | initdb --pwfile /dev/zero |
| Date: | 2021-09-17 17:46:44 |
| Message-ID: | 20210917174644.7pjxxinc5je23djh@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
A colleague tried PG 14 internally and it failed during cluster creation, when
using the PGDG rpm packages. A bit of debugging shows that the problem is
that the packaging script specifies the password using --pwfile /dev/zero.
In 14+ this turns out to lead to an endless loop in pg_get_line_append().
The --pwfile /dev/zero was added in
https://git.postgresql.org/gitweb/?p=pgrpms.git;a=commitdiff;h=8ca418709ef49a1781f0ea8e6166b139106135ff
Devrim, what was the goal? Even in 13 this didn't achieve anything?
While I don't think passing /dev/zero is a good idea (it mostly seems to
circumvent ""password file \"%s\" is empty", without achieving anything, given
the password will be empty). I think we still ought to make pg_get_line() a
bit more resilient against '\0'?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-09-17 18:48:42 | Re: initdb --pwfile /dev/zero |
| Previous Message | Alvaro Herrera | 2021-09-17 17:34:20 | Re: prevent immature WAL streaming |