Re: initdb --pwfile /dev/zero

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Devrim Gündüz <devrim(at)gunduz(dot)org>, pgsql-hackers(at)postgresql(dot)org, philip(dot)dub(at)microsoft(dot)com, jelte(dot)fennema(at)microsoft(dot)com
Subject: Re: initdb --pwfile /dev/zero
Date: 2021-09-17 18:48:42
Message-ID: 1346090.1631904522@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> A colleague tried PG 14 internally and it failed during cluster creation, when
> using the PGDG rpm packages. A bit of debugging shows that the problem is
> that the packaging script specifies the password using --pwfile /dev/zero.

> In 14+ this turns out to lead to an endless loop in pg_get_line_append().

Well, that's because that file will source an infinite amount of stuff.

> I think we still ought to make pg_get_line() a
> bit more resilient against '\0'?

I don't think '\0' is the problem. The only fix for this would be to
re-introduce some fixed limit on how long a line we'll read, which
I'm not too thrilled about. I think this is better classified as
user error.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2021-09-17 18:50:34 Re: prevent immature WAL streaming
Previous Message Andres Freund 2021-09-17 17:46:44 initdb --pwfile /dev/zero