| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Dave Cramer <davecramer(at)gmail(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_upgrade does not upgrade pg_stat_statements properly |
| Date: | 2021-07-29 16:34:48 |
| Message-ID: | 20210729163448.GP9600@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 29, 2021 at 12:22:59PM -0400, Dave Cramer wrote:
> On Thu, 29 Jul 2021 at 12:16, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Can you review the text I just posted? Thanks. I think we are making
> progress. ;-)
>
>
> I am OK with Everything except
>
> Do not load the schema definitions,
> e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
> will be recreated from the old cluster. (The extensions may be
> upgraded later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
>
> I take issue with the word "recreated". This implies something new is created,
> when in fact the old definitions are simply copied over.
>
> As I said earlier; using the wording "may be upgraded" is not nearly cautionary
> enough.
OK, I changed it to "copy" though I used "recreated" earlier since I was
worried "copy" would be confused with file copy. I changed the
recommendation to "should be".
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
| Attachment | Content-Type | Size |
|---|---|---|
| pg_upgrade.diff | text/x-diff | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2021-07-29 16:44:30 | Re: pg_upgrade does not upgrade pg_stat_statements properly |
| Previous Message | Jan Wieck | 2021-07-29 16:28:42 | Re: pg_upgrade does not upgrade pg_stat_statements properly |