Re: Configure with thread sanitizer fails the thread test

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Mikhail Matrosov <mikhail(dot)matrosov(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, ewan_higgs(at)yahoo(dot)co(dot)uk, andres(at)anarazel(dot)de, robertmhaas(at)gmail(dot)com
Subject: Re: Configure with thread sanitizer fails the thread test
Date: 2021-07-23 17:36:54
Message-ID: 202107231736.ahqg4xiuob7f@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Jul-23, Alvaro Herrera wrote:

> On 2021-Jul-23, Mikhail Matrosov wrote:
>
> > I am not sure what is the proper fix for the issue, but I at least suggest
> > to disable this test when building with thread sanitizer:
> > https://github.com/conan-io/conan-center-index/pull/6472/files#diff-b8639f81e30f36c8ba29a0878f1ef4d9f1552293bc9098ebb9b429ddb1f0935f
>
> Here's the proposed patch. Patches posted to the mailing list by their
> authors proposed for inclusion are considered to be under the PostgreSQL
> license, but this patch hasn't been posted by the author so let's assume
> they're not authorizing them to use it. (Otherwise, why wouldn't they
> just post it here instead of doing the absurdly convoluted dance of a
> github PR?)

... that said, I wonder why would we do this in the thread_test program
rather than in configure itself. Wouldn't it make more sense for the
configure test to be skipped altogether (marking the result as
thread-safe) when running under thread sanitizer, if there's a way to
detect that?

--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"No me acuerdo, pero no es cierto. No es cierto, y si fuera cierto,
no me acuerdo." (Augusto Pinochet a una corte de justicia)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-07-23 17:42:41 Re: Configure with thread sanitizer fails the thread test
Previous Message Alvaro Herrera 2021-07-23 17:35:22 Re: Configure with thread sanitizer fails the thread test