Re: Configure with thread sanitizer fails the thread test

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Mikhail Matrosov <mikhail(dot)matrosov(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, ewan_higgs(at)yahoo(dot)co(dot)uk, andres(at)anarazel(dot)de, robertmhaas(at)gmail(dot)com
Subject: Re: Configure with thread sanitizer fails the thread test
Date: 2021-07-23 17:35:22
Message-ID: 202107231735.yhuvz7hfgkun@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Jul-23, Mikhail Matrosov wrote:

> I am not sure what is the proper fix for the issue, but I at least suggest
> to disable this test when building with thread sanitizer:
> https://github.com/conan-io/conan-center-index/pull/6472/files#diff-b8639f81e30f36c8ba29a0878f1ef4d9f1552293bc9098ebb9b429ddb1f0935f

Here's the proposed patch. Patches posted to the mailing list by their
authors proposed for inclusion are considered to be under the PostgreSQL
license, but this patch hasn't been posted by the author so let's assume
they're not authorizing them to use it. (Otherwise, why wouldn't they
just post it here instead of doing the absurdly convoluted dance of a
github PR?)

diff --git a/src/test/thread/thread_test.c b/src/test/thread/thread_test.c
index e1bec01..e4ffd78 100644
--- a/src/test/thread/thread_test.c
+++ b/src/test/thread/thread_test.c
@@ -61,6 +61,14 @@ main(int argc, char *argv[])
fprintf(stderr, "Perhaps rerun 'configure' using '--enable-thread-safety'.\n");
return 1;
}
+
+#elif __has_feature(thread_sanitizer)
+int
+main(int argc, char *argv[])
+{
+ printf("Thread safety check is skipped since it does not work with thread sanitizer.\n");
+ return 0;
+}
#else

/* This must be down here because this is the code that uses threads. */

--
Álvaro Herrera

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-07-23 17:36:54 Re: Configure with thread sanitizer fails the thread test
Previous Message Stephen Frost 2021-07-23 16:20:29 Re: Delegating superuser tasks to new security roles (Was: Granting control of SUSET gucs to non-superusers)