| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: unnesting multirange data types |
| Date: | 2021-06-15 17:28:27 |
| Message-ID: | 202106151728.5kbtjl7or3g2@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jun-15, Tom Lane wrote:
> It looks to me like the proximate problem is that you should
> have taught pg_dump to skip these new auto-generated functions.
> However, I fail to see why we need auto-generated functions
> for this at all. Couldn't we have done it with one polymorphic
> function?
I think such a function would need to take anycompatiblerangearray,
which is not something we currently have.
> I think this ought to be reverted and reviewed more carefully.
It seems to me that removing the cast-to-range[] is a sufficient fix,
and that we can do with only the unnest part for pg14; the casts can be
added in 15 (if at all). That would mean reverting only half the patch.
--
Álvaro Herrera 39°49'30"S 73°17'W
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-06-15 17:28:58 | Re: [PATCH] Fix buffer not null terminated on (ecpg lib) |
| Previous Message | Tom Lane | 2021-06-15 17:18:06 | Re: unnesting multirange data types |