Re: Adjust pg_regress output for new long test names

From: Noah Misch <noah(at)leadboat(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adjust pg_regress output for new long test names
Date: 2021-06-09 02:51:29
Message-ID: 20210609025129.GC475088@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 09, 2021 at 01:57:45PM +1200, Thomas Munro wrote:
> test deadlock-simple ... ok 20 ms
> test deadlock-hard ... ok 10624 ms
> test deadlock-soft ... ok 147 ms
> test deadlock-soft-2 ... ok 5154 ms
> test deadlock-parallel ... ok 132 ms
> test detach-partition-concurrently-1 ... ok 553 ms
> test detach-partition-concurrently-2 ... ok 234 ms
> test detach-partition-concurrently-3 ... ok 2389 ms
> test detach-partition-concurrently-4 ... ok 1876 ms

> Make the test output visually consistent, as previously done by commit
> 14378245.

Not bad, but I would instead shorten the names to detach-[1234] or
detach-partition-[1234]. The marginal value of the second word is low, and
the third word helps even less.

> - status(_("test %-28s ... "), tests[0]);
> + status(_("test %-32s ... "), tests[0]);

As the whitespace gulf widens, it gets harder to match left and right sides
visually. We'd cope of course, but wider spacing isn't quite free.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-06-09 03:06:23 Re: locking [user] catalog tables vs 2pc vs logical rep
Previous Message Michael Paquier 2021-06-09 02:50:10 Re: Unused function parameter in get_qual_from_partbound()