| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, iwata(dot)aya(at)fujitsu(dot)com, tsunakawa(dot)takay(at)fujitsu(dot)com, k(dot)jamison(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: libpq debug log |
| Date: | 2021-06-05 15:02:49 |
| Message-ID: | 202106051502.l252ugdz7cg6@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jun-04, Noah Misch wrote:
> On Fri, Apr 09, 2021 at 05:16:11PM -0400, Alvaro Herrera wrote:
> > Pushed now.
>
> This added a PQtraceSetFlags() function. We have a dozen PQset*() functions,
> but this and PQresultSetInstanceData() are the only PQSomethingSet()
> functions. Is it okay if I rename it to PQsetTraceFlags()? I think that
> would be more idiomatic for libpq.
Hmm, there is an obvious parallel between PQtrace() and
PQtraceSetFlags() which is lost with your proposed rename. I'm not
wedded to the name though, so I'm just -0.1 on the rename. If you feel
strongly about it, I won't oppose it.
--
Álvaro Herrera Valdivia, Chile
"La espina, desde que nace, ya pincha" (Proverbio africano)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhihong Yu | 2021-06-05 16:47:45 | Re: Table AM modifications to accept column projection lists |
| Previous Message | Fabien COELHO | 2021-06-05 14:31:32 | Re: Failures with gcd functions with GCC snapshots GCC and -O3 (?) |