| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Atsushi Torikoshi <atorik(at)gmail(dot)com>, Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Evgeny Efimkin <efimkin(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
| Date: | 2021-04-08 03:27:04 |
| Message-ID: | 20210408032704.GA7498@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Apr-07, Bruce Momjian wrote:
> On Thu, Apr 8, 2021 at 10:38:08AM +0800, Julien Rouhaud wrote:
> > Thanks! And I agree with using query_id in the new field names while keeping
> > queryid for pg_stat_statements to avoid unnecessary query breakage.
>
> I think we need more feedback from the group. Do people agree with the
> idea above? The question is what to call:
>
> GUC compute_queryid
> pg_stat_activity.queryid
> pg_stat_statements.queryid
>
> using "queryid" or "query_id", and do they have to match?
Seems a matter of personal preference. Mine is to have the underscore
everywhere in backend code (where this is new), and let it without the
underscore in pg_stat_statements to avoid breaking existing code. Seems
to match what Julien is saying.
--
Álvaro Herrera Valdivia, Chile
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-04-08 03:28:34 | Re: SQL-standard function body |
| Previous Message | Amit Kapila | 2021-04-08 03:24:58 | Re: Set access strategy for parallel vacuum workers |