| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, yuzuko <yuzukohosoya(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Amit Langote <amitlangote09(at)gmail(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu> |
| Subject: | Re: Autovacuum on partitioned table (autoanalyze) |
| Date: | 2021-04-06 23:58:37 |
| Message-ID: | 20210406235837.qym42yn7lsnxzlir@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-04-06 16:56:49 -0400, Alvaro Herrera wrote:
> I think there is a good reason to treat them the same: pgstat does not
> have a provision to keep stats both of the table with children, and the
> table without children. It can only have one of those. For
> partitioning that doesn't matter: since the table-without-children
> doesn't have anything on its own (no scans, no tuples, no nothing) then
> we can just use the entry to store the table-with-children data. But
> for the inheritance case, the parent can have its own tuples and counts
> its own scans and so on; so if we change things, we'll overwrite the
> stats. Maybe in the long-term we should allow pgstat to differentiate
> those cases, but that seems not in scope for this patch.
FWIW, I think it shouldn't be too hard to do that once the shared memory
stats patch goes in (not 14, unfortunately). The hardest part will be to
avoid exploding the number of interface functions, but I think we can
figure out a way to deal with that.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-04-07 00:00:25 | Re: ModifyTable overheads in generic plans |
| Previous Message | Alvaro Herrera | 2021-04-06 23:49:07 | Re: Remove page-read callback from XLogReaderState. |