| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, takashi(dot)menjo(at)gmail(dot)com, Craig Ringer <craig(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, takashi(dot)menjou(dot)vg(at)hco(dot)ntt(dot)co(dot)jp |
| Subject: | Re: Remove page-read callback from XLogReaderState. |
| Date: | 2021-04-06 23:49:07 |
| Message-ID: | 20210406234907.GA19311@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Apr-07, Thomas Munro wrote:
> On Wed, Apr 7, 2021 at 11:18 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > BTRW it's funny that after these patches, "xlogreader" no longer reads
> > anything. It's more an "xlog interpreter" -- the piece of code that
> > splits individual WAL records from a stream of WAL bytes that's caller's
> > responsibility to obtain somehow. But (and, again, I haven't read this
> > patch recently) it still offers pieces that support a reader, in
> > addition to its main interface as the interpreter. Maybe it's not a
> > totally stupid idea to split it in even more different files.
>
> Yeah, I like "decoder", and it's already called that in some places...
Yeah, that works ...
--
Álvaro Herrera 39°49'30"S 73°17'W
"Los trabajadores menos efectivos son sistematicamente llevados al lugar
donde pueden hacer el menor daño posible: gerencia." (El principio Dilbert)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-04-06 23:58:37 | Re: Autovacuum on partitioned table (autoanalyze) |
| Previous Message | Thomas Munro | 2021-04-06 23:37:11 | Re: Remove page-read callback from XLogReaderState. |