| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_amcheck contrib application |
| Date: | 2021-03-13 06:16:55 |
| Message-ID: | 20210313061655.GC3099026@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 13, 2021 at 01:07:15AM -0500, Tom Lane wrote:
> I wrote:
> >> ... btw, prairiedog (which has a rather old Perl) has a
> >> different complaint:
> >> Invalid type 'q' in unpack at t/004_verify_heapam.pl line 104.
>
> > Hmm ... "man perlfunc" on that system quoth
> > q A signed quad (64-bit) value.
> > Q An unsigned quad value.
> > (Quads are available only if your system supports 64-bit
> > integer values _and_ if Perl has been compiled to support those.
> > Causes a fatal error otherwise.)
> > It does not seem unreasonable for us to rely on Perl having that
> > in 2021, so I'll see about upgrading this perl installation.
>
> Hm, wait a minute: hoverfly is showing the same failure, even though
> it claims to be running a 64-bit Perl. Now I'm confused.
On that machine:
[nm(at)power8-aix 7:0 2021-03-13T06:09:08 ~ 0]$ /usr/bin/perl64 -e 'unpack "q", ""'
[nm(at)power8-aix 7:0 2021-03-13T06:09:10 ~ 0]$ /usr/bin/perl -e 'unpack "q", ""'
Invalid type 'q' in unpack at -e line 1.
hoverfly does configure with PERL=perl64. /usr/bin/prove is from the 32-bit
Perl, so I suspect the TAP suites get 32-bit Perl that way. (There's no
"prove64".) This test should unpack the field as two 32-bit values, not a
64-bit value, to avoid requiring more from the Perl installation.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2021-03-13 06:18:32 | Re: pg_amcheck contrib application |
| Previous Message | Tom Lane | 2021-03-13 06:07:15 | Re: pg_amcheck contrib application |