| From: | 'Alvaro Herrera' <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
| Cc: | "iwata(dot)aya(at)fujitsu(dot)com" <iwata(dot)aya(at)fujitsu(dot)com>, "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: libpq debug log |
| Date: | 2021-02-03 14:01:54 |
| Message-ID: | 20210203140154.GA25582@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Feb-03, tsunakawa(dot)takay(at)fujitsu(dot)com wrote:
> (39)
> + of tracing. If (<literal>flags</literal> & <literal>PQTRACE_OUTPUT_TIMESTAMPS</literal>) is
> + true, then timestamp is not printed with each message.
>
> The flag name (OUTPUT) and its description (not printed) doesn't match.
>
> I think you can use less programmatical expression like "If <literal>flags</literal> contains <literal>PQTRACE_OUTPUT_TIMESTAMPS</literal>".
I copied the original style from elsewhere in the manual.
> (41)
> +void
> +PQtraceEx(PGconn *conn, FILE *debug_port, int flags)
> +{
I'm not really sure about making this a separate API call. We could just
make it PQtrace() and increment the libpq so version. I don't think
it's a big deal, frankly.
--
Álvaro Herrera 39°49'30"S 73°17'W
"El conflicto es el camino real hacia la unión"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 'Alvaro Herrera' | 2021-02-03 14:02:18 | Re: libpq debug log |
| Previous Message | Alvaro Herrera | 2021-02-03 13:58:59 | Re: libpq debug log |