| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e |
| Date: | 2020-12-24 23:31:25 |
| Message-ID: | 20201224233125.GB21105@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Dec 24, 2020 at 06:25:56PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > revert removal of hex_decode() from ecpg from commit c3826f831e
> > ecpglib on certain platforms can't handle the pg_log_fatal calls from
> > libraries. This was reported by the buildfarm. It needs a refactoring
> > and return value change if it is later removed.
>
> Just for the record: even without the link failures, this was a pretty
> awful idea. ecpglib has no business calling pg_log_fatal(), much less
> exit().
I should have realized it was the _lib_ calling it, and not ecpg itself.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-12-25 00:04:41 | Re: pgsql: move hex_decode() to /common so it can be called from frontend |
| Previous Message | Tom Lane | 2020-12-24 23:25:56 | Re: pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e |