Re: pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e
Date: 2020-12-24 23:25:56
Message-ID: 1080732.1608852356@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> revert removal of hex_decode() from ecpg from commit c3826f831e
> ecpglib on certain platforms can't handle the pg_log_fatal calls from
> libraries. This was reported by the buildfarm. It needs a refactoring
> and return value change if it is later removed.

Just for the record: even without the link failures, this was a pretty
awful idea. ecpglib has no business calling pg_log_fatal(), much less
exit().

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-24 23:31:25 Re: pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e
Previous Message Bruce Momjian 2020-12-24 23:21:49 pgsql: revert removal of hex_decode() from ecpg from commit c3826f831e