Re: Wrong example in the bloom documentation

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong example in the bloom documentation
Date: 2020-10-09 15:08:32
Message-ID: 20201009150832.GB1459@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Fri, Oct 9, 2020 at 05:44:57AM +0000, Daniel Westermann (DWE) wrote:
> Hi Bruce, Tom,
>
> On Thu, Oct  8, 2020 at 03:43:32PM -0400, Tom Lane wrote:
> >> "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com> writes:
> >> >> I was hoping someone more experienced with this would comment, but
> >> >> seeing none, I will apply it in a day or two to all supported versions?
> >> >> Have you tested this output back to 9.5?
> >>
> >> > I hoped that as well. No, I tested down to 9.6 because the change happened in 10.
> >>
> >> The patch assumes that parallel query is enabled, which is not true by
> >> default before v10, so it should certainly not be applied before v10
> >> (at least not without significant revisions).
>
> Yes, the behavior change was in 10. Before 10 the example is fine, I would not apply that to any prior version, otherwise the whole example needs to be rewritten.

Agreed.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message David G. Johnston 2020-10-12 00:16:38 Re: nondeterministic collations and statistics and pattern matching
Previous Message Daniel Westermann (DWE) 2020-10-09 05:44:57 Re: Wrong example in the bloom documentation

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2020-10-09 15:24:16 Possible NULL dereferencing null pointer (src/backend/executor/nodeIncrementalSort.c)
Previous Message Alvaro Herrera 2020-10-09 14:48:59 Re: libpq debug log