| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add primary keys to system catalogs |
| Date: | 2020-10-06 18:34:50 |
| Message-ID: | 20201006183450.f4jn7vzwsokqwgi2@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2020-10-03 08:40:31 +0200, Peter Eisentraut wrote:
> Since we have ADD PRIMARY KEY USING INDEX, we can declare a primary key for
> an existing index. So this doesn't have to affect the low-level early
> bootstrapping. The attached patch adds those commands manually. Another
> option might be to have the catalog generation Perl tooling create those
> declarations automatically from some marker in the catalog files. That
> would also allow declaring unique constraints for the unique indexes that
> don't end up being the primary key.
Hm. What prevents us from declaring the pkey during bootstrap? I don't
at all like adding yet another place that needs manual editing when
doing DDL changes.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2020-10-06 18:45:21 | Re: pg_upgrade dead code for pre-8.4 versions |
| Previous Message | Andres Freund | 2020-10-06 18:27:48 | Re: A modest proposal: let's add PID to assertion failure messages |