Re: A modest proposal: let's add PID to assertion failure messages

From: Andres Freund <andres(at)anarazel(dot)de>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: A modest proposal: let's add PID to assertion failure messages
Date: 2020-10-06 18:27:48
Message-ID: 20201006182748.ktk4se2gi4b3ggoy@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-10-05 10:20:01 +1300, Thomas Munro wrote:
> On Mon, Oct 5, 2020 at 10:08 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > In these days when we run almost all test cases in parallel, it's
> > frequently not that easy to tie a "TRAP: ..." message in the log
> > to nearby log messages. (The postmaster's subsequent complaint
> > often helps, but it could be some distance away in the log; and
> > good luck untangling things if more than one Assert failure happens
> > concurrently.) We could add a simple bread crumb trail by
> > including the process's PID in such messages. Any objections?
>
> +1

+1

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-10-06 18:34:50 Re: Add primary keys to system catalogs
Previous Message Anastasia Lubennikova 2020-10-06 17:25:48 Re: [PATCH] Automatic HASH and LIST partition creation