Re: BUG #16594: DROP INDEX CONCURRENTLY fails on partitioned table with a non helpful error message.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: jan(dot)mussler(at)zalando(dot)de, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16594: DROP INDEX CONCURRENTLY fails on partitioned table with a non helpful error message.
Date: 2020-09-01 17:44:08
Message-ID: 20200901174408.GA6628@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2020-Sep-01, Michael Paquier wrote:

> On Mon, Aug 31, 2020 at 09:25:53PM -0400, Alvaro Herrera wrote:
> > Actually I think you're wrong; if I put it before the check, then if I
> > do "drop index concurrently some_temp_partitioned_index" then it would
> > fail; but if I put it after the check, then it does a normal
> > non-concurrent index and it works. I'm not sure it's necessary to break
> > a case that otherwise works ...
>
> Hmm. Right. I agree that it would be better to not break that case.
> And it means that there is a gap in the regression tests here, so I'd
> like to add a test. Please see the attached to achieve that, which
> includes your own code changes and the doc parts

Agreed -- thanks for that.

> (I didn't see a point in changing the new sentence for temporary
> relations as the follow-up <para> mentions that).

Yeah, I had come to the same conclusion.

Pushed now to all branches, thanks.

Thanks, Jan, for reporting this bug.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Yash Raj 2020-09-01 18:27:32 Re: BUG #16601: Restore Issue
Previous Message Stephen Frost 2020-09-01 16:16:48 Re: BUG #16603: Permission issue