From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | jan(dot)mussler(at)zalando(dot)de, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #16594: DROP INDEX CONCURRENTLY fails on partitioned table with a non helpful error message. |
Date: | 2020-09-01 02:58:35 |
Message-ID: | 20200901025835.GC3511@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Mon, Aug 31, 2020 at 09:25:53PM -0400, Alvaro Herrera wrote:
> Actually I think you're wrong; if I put it before the check, then if I
> do "drop index concurrently some_temp_partitioned_index" then it would
> fail; but if I put it after the check, then it does a normal
> non-concurrent index and it works. I'm not sure it's necessary to break
> a case that otherwise works ...
Hmm. Right. I agree that it would be better to not break that case.
And it means that there is a gap in the regression tests here, so I'd
like to add a test. Please see the attached to achieve that, which
includes your own code changes and the doc parts (I didn't see a point
in changing the new sentence for temporary relations as the follow-up
<para> mentions that).
> (But for that to work I need to test the flag in the bitmask rather than
> the option in the command, as in the attached).
Make sense.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
reindex-drop-part-michael.patch | text/x-diff | 4.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | KANGQIAOPING754 | 2020-09-01 10:49:56 | 答复: a segfault failure of query |
Previous Message | Alvaro Herrera | 2020-09-01 01:30:21 | Re: BUG #16594: DROP INDEX CONCURRENTLY fails on partitioned table with a non helpful error message. |