| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | amit(dot)kapila16(at)gmail(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com, michael(at)paquier(dot)xyz, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: min_safe_lsn column in pg_replication_slots view |
| Date: | 2020-07-07 17:48:00 |
| Message-ID: | 20200707174800.GA17240@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Jul-06, Alvaro Herrera wrote:
> On 2020-Jul-07, Kyotaro Horiguchi wrote:
> > Couldn't we move ConvertToXSegs from xlog.c to xlog_ingernals.h and
> > use it intead of the bare expression?
>
> I was of two minds about that, and the only reason I didn't do it is
> that we'll need to give it a better name if we do it ... I'm open to
> suggestions.
In absence of other suggestions I gave this the name XLogMBVarToSegs,
and redefined ConvertToXSegs to use that. Didn't touch callers in
xlog.c to avoid pointless churn. Pushed to both master and 13.
I hope this satisfies everyone ... Masao-san, thanks for reporting the
problem, and thanks Horiguchi-san for providing the fix. (Also thanks
to Amit and Michael for discussion.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-07-07 17:53:11 | Re: OpenSSL 3.0.0 compatibility |
| Previous Message | Alvaro Herrera | 2020-07-07 17:46:17 | Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical () at walsender.c:2762 |