Re: src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h

From: Christoph Berg <myon(at)debian(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h
Date: 2020-05-08 19:45:33
Message-ID: 20200508194533.GB165095@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Re: Tom Lane
> But during "make check", that should be executing pg_config from the
> the temporary installation, so we should get the right answer no?
>
> Conversely, in "make installcheck" scenarios, we definitely do want
> the value from the installed file, or so I should think.
>
> Do you have a concrete scenario where you're getting wrong behavior?

I just added the extra tests to the postgresql-13 package and got
this:

$ cat build/src/test/ssl/tmp_check/log/regress_log_002_scram
No such file or directory at /srv/projects/postgresql/pg/master/build/../src/test/perl/TestLib.pm line 595.

But I just realized that the problem is caused by a Debian-specific
patch that removes the find_my_exec logic from pg_config and replaces
it with PGBINDIR. We need that patch because we install pg_config to
both /usr/bin and /usr/lib/postgresql/<version>/bin and want the same
output from both.

I'll revisit that to see if we can come up with a different solution.

Christoph

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2020-05-08 20:04:26 Re: Improving estimates for TPC-H Q2
Previous Message Tom Lane 2020-05-08 19:34:31 Re: src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h