Re: src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h
Date: 2020-05-08 19:34:31
Message-ID: 11682.1588966471@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Christoph Berg <myon(at)debian(dot)org> writes:
> I believe check_pg_config as used by src/test/ssl/t/002_scram.pl
> shouldn't rely on /usr/include/postgresql/pg_config.h but use the file
> from the build tree instead:

But during "make check", that should be executing pg_config from the
the temporary installation, so we should get the right answer no?

Conversely, in "make installcheck" scenarios, we definitely do want
the value from the installed file, or so I should think.

Do you have a concrete scenario where you're getting wrong behavior?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2020-05-08 19:45:33 Re: src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h
Previous Message Christoph Berg 2020-05-08 19:16:44 src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h