| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: documenting the backup manifest file format |
| Date: | 2020-04-13 19:34:49 |
| Message-ID: | 20200413193449.GA14498@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
+ The LSN at which replay must begin on the indicated timeline in order to
+ make use of this backup. The LSN is stored in the format normally used
+ by <productname>PostgreSQL</productname>; that is, it is a string
+ consisting of two strings of hexademical characters, each with a length
+ of between 1 and 8, separated by a slash.
typo "hexademical"
Are these hex figures upper or lower case? No leading zeroes? This
would normally not matter, but the toplevel checksum will care. Also, I
see no mention of prettification-chars such as newlines or indentation.
I suppose if I pass a manifest file through prettification (or Windows
newline conversion), the checksum may break.
As for Last-Modification, I think the spec should indicate the exact
format that's used, because it'll also be critical for checksumming.
Why is the top-level checksum only allowed to be SHA-256, if the files
can use up to SHA-512? (Also, did we intentionally omit the dash in
hash names, so "SHA-256" to make it SHA256? This will also be critical
for checksumming the manifest itself.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fred Richard | 2020-04-13 19:48:37 | Using Oracle SQL Client commands with PSQL 12.2 DB |
| Previous Message | Tom Lane | 2020-04-13 18:47:27 | Re: Poll: are people okay with function/operator table redesign? |