Re: doc review for parallel vacuum

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: doc review for parallel vacuum
Date: 2020-04-10 13:46:44
Message-ID: 20200410134644.GB2228@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 10, 2020 at 12:56:08PM +0530, Amit Kapila wrote:
> On Wed, Apr 8, 2020 at 12:49 PM Masahiko Sawada
> <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> >
> > On Tue, 7 Apr 2020 at 13:55, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > >
> >
> > I don't have comments on your change other than the comments Amit
> > already sent. Thank you for reviewing this part!
> >
>
> I have made the modifications as per my comments. What do you think
> about the attached?

Couple more changes (in bold):

- The <option>PARALLEL</option> option is used only for vacuum PURPOSES.
- Even if this option is specified with THE <option>ANALYZE</option> option

Also, this part still doesn't read well:

- * amvacuumcleanup to the DSM segment if it's the first time to get it?
- * from them? because they? allocate it locally and it's possible that an
- * index will be vacuumed by the different vacuum process at the next

If you change "it" and "them" and "it" and say "*a* different", then it'll be
ok.

--
Justin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-04-10 13:49:07 Re: where should I stick that backup?
Previous Message Justin Pryzby 2020-04-10 13:35:32 Re: Vacuum o/p with (full 1, parallel 0) option throwing an error