| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | daniel(at)yesql(dot)se, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PG_COLOR not mentioned in docs of vacuumlo, oid2name and pgbench |
| Date: | 2020-03-07 01:09:23 |
| Message-ID: | 20200307010923.GB1531@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 05, 2020 at 10:09:31AM +0100, Juan José Santamaría Flecha wrote:
> On Thu, Mar 5, 2020 at 9:40 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> LGTM
>
> +1
Thanks to both of you for the reviews. Please note that I will
mention the business with pg_ctl and logging in a new thread and
remove the diff of pg_ctl.c from the previous patch, and that the doc
changes could be backpatched down to 12 for the relevant parts. The
documentation for PG_COLORS is still missing, but that's not new and I
think that we had better handle that case separately by creating a new
section in the docs. For now, let's wait a couple of days and see if
others have more thoughts to share about the doc patch of this thread.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-03-07 01:41:42 | Re: Add an optional timeout clause to isolationtester step. |
| Previous Message | Michael Paquier | 2020-03-07 01:03:40 | Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions |