Re: Allow relocatable extension to use @extschema@?

On Thu, Dec 05, 2019 at 09:52:50AM -0500, Robert Haas wrote:
> On Tue, Dec 3, 2019 at 10:18 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> writes:
> > > But nevertheless should we allow relocatable extension to use
> > > @extschema(at)(dot) Any thoughts?
> >
> > No. The reasoning in the comment still holds good: if you embed
> > @extschema@ in an object's definition, it becomes nonrelocatable.
>
> That's demonstrably false, and the links included in the OP prove it.

Right. Or, to add further precision, embedding @extschema@ persistently in
the system catalogs does make the extension nonrelocatable. The OP examples
merely embed @extschema@ in extension scripts, and they don't impair
relocation. I'm okay with the proposal, but I still wouldn't mind deprecating
relocatable=true.