Re: pgsql: Rename files and headers related to index AM

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Rename files and headers related to index AM
Date: 2019-12-28 10:10:24
Message-ID: 20191228101024.ckw3iz3naouxoxzn@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2019-12-27 08:20:17 +0900, Michael Paquier wrote:
> On Thu, Dec 26, 2019 at 10:26:51AM -0800, Peter Geoghegan wrote:
> > On Thu, Dec 26, 2019 at 10:15 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> Yea, this seems like a much bigger move than warranted. Especially
> >> without a backward compat header put into place.
>
> Hm, I am not sure that it is actually that much used, such stuff is
> very specialized.

That's true for some of this, but e.g. genam.h is pretty widely
included. I mean, you had to adapt like 100+ files and while like 30 or
so of those are in implementation details of individual indexes, the
rest is not.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-12-28 16:32:26 Re: pgsql: Rename files and headers related to index AM
Previous Message Alvaro Herrera 2019-12-27 21:35:31 pgsql: Add pg_dump test for triggers on partitioned tables