| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Rename files and headers related to index AM |
| Date: | 2019-12-28 16:32:26 |
| Message-ID: | 18016.1577550746@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-12-27 08:20:17 +0900, Michael Paquier wrote:
>> Hm, I am not sure that it is actually that much used, such stuff is
>> very specialized.
> That's true for some of this, but e.g. genam.h is pretty widely
> included. I mean, you had to adapt like 100+ files and while like 30 or
> so of those are in implementation details of individual indexes, the
> rest is not.
This may suggest that we should think about an actual refactoring,
rather than just mechanical renaming. Do these results mean that
we've allowed index API details to bleed into the wrong places?
(Probably ought to take this thread to -hackers if anyone wants
to discuss that.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-12-28 22:21:38 | pgsql: Micro-optimize AllocSetFreeIndex() by reference to pg_bitutils c |
| Previous Message | Andres Freund | 2019-12-28 10:10:24 | Re: pgsql: Rename files and headers related to index AM |