Re: pgsql: Emit parameter values during query bind/execute errors

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Emit parameter values during query bind/execute errors
Date: 2019-12-12 16:47:20
Message-ID: 20191212164720.GA27169@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019-Dec-12, Tom Lane wrote:

> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Emit parameter values during query bind/execute errors
>
> (Some of?) the Windows buildfarm critters don't like the test
> case you added. I speculate that the test pattern is neglecting
> to allow for Windows-style newlines.

Hmm, the affected ones (jacana and fairywren only AFAICS) seem to be
gcc-based, which presumably work differently than the msvc-based in how
newlines are interpreted in the test script. I pushed an attempted
blind fix.

I *hope* that those two are not the only Windows ones running the
pgbench tap test!

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-12-12 17:13:17 pgsql: Remove redundant function calls in timestamp[tz]_part().
Previous Message Alvaro Herrera 2019-12-12 16:45:51 pgsql: (Blindly) tweak new test regex