Re: pgsql: Emit parameter values during query bind/execute errors

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pgsql: Emit parameter values during query bind/execute errors
Date: 2019-12-12 17:41:26
Message-ID: 2001.1576172486@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Hmm, the affected ones (jacana and fairywren only AFAICS) seem to be
> gcc-based, which presumably work differently than the msvc-based in how
> newlines are interpreted in the test script. I pushed an attempted
> blind fix.

> I *hope* that those two are not the only Windows ones running the
> pgbench tap test!

[ scrapes buildfarm results... ] The Windows critters that are
running that test seem to be

name | operating_system | compiler
-----------+------------------+---------------
bowerbird | Windows | Visual Studio
drongo | Windows | Visual Studio
fairywren | Windows / Msys | gcc
jacana | Windows | gcc

So yeah, the MSVC ones were happy with the test as you had it.
Interesting ... it's not obvious why that would have anything
to do with the behavior of a Perl regexp. Maybe they are using
a different Perl version?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-12-12 18:50:01 pgsql: Put back regression test case in a more robust form.
Previous Message Tom Lane 2019-12-12 17:31:05 pgsql: Fix EXTRACT(ISOYEAR FROM timestamp) for years BC.