| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | a(dot)lepikhov(at)postgrespro(dot)ru |
| Cc: | masao(dot)fujii(at)gmail(dot)com, michael(at)paquier(dot)xyz, alvherre(at)2ndquadrant(dot)com, thomas(dot)munro(at)gmail(dot)com, rjuju123(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org, vignesh21(at)gmail(dot)com |
| Subject: | Re: pg_waldump and PREPARE |
| Date: | 2019-11-08 04:26:18 |
| Message-ID: | 20191108.132618.1946785516798153399.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello.
At Fri, 8 Nov 2019 08:23:41 +0500, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> wrote in
> > Can I switch the status back to "Needs review"?
> > Regards,
> >
>
> One issue is that your patch provides small information. WAL errors
> Investigation often requires information on xid, subxacts,
> delete-on-abort/commit rels; rarely - invalidation messages etc.
Basically agrred, but it can be very large in certain cases, even if
it is rare.
By the way, in the patch xact_desc_prepare seems printing
parseed.xact_time, which is not actually set by ParsePrepareRecord.
# I missed the funtion. xl_xact_prepare is used in *two* places in
# front end.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-11-08 04:27:46 | Re: adding partitioned tables to publications |
| Previous Message | Kyotaro Horiguchi | 2019-11-08 04:14:55 | Re: pg_waldump and PREPARE |