From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: RFC: split OBJS lines to one object per line |
Date: | 2019-11-05 22:47:55 |
Message-ID: | 20191105224755.egcef7gx7jota4bz@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2019-10-29 23:32:09 -0700, Andres Freund wrote:
> On 2019-10-29 16:31:11 -0400, Tom Lane wrote:
> > Andres Freund <andres(at)anarazel(dot)de> writes:
> > > one of the most frequent conflicts I see is that two patches add files
> > > to OBJS (or one of its other spellings), and there are conflicts because
> > > another file has been added.
> > > ...
> > > Now, obviously these types of conflicts are easy enough to resolve, but
> > > it's still annoying. It seems that this would be substantially less
> > > often a problem if we just split such lines to one file per
> > > line.
> >
> > We did something similar not too long ago in configure.in (bfa6c5a0c),
> > and it seems to have helped. +1
>
> Cool. Any opinion on whether to got for
>
> OBJS = \
> dest.o \
> fastpath.o \
> ...
>
> or
>
> OBJS = dest.o \
> fastpath.o \
> ...
>
> I'm mildly inclined to go for the former.
Pushed a patch going with the former. Let's see what the buildfarm
says...
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2019-11-05 22:53:35 | Re: [HACKERS] WAL logging problem in 9.4.3? |
Previous Message | Alvaro Herrera | 2019-11-05 21:29:16 | Re: deferrable FK constraints on partitioned rels |