| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: RFC: split OBJS lines to one object per line |
| Date: | 2019-10-30 06:32:09 |
| Message-ID: | 20191030063209.mr2ksylefsrcbu6z@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-10-29 16:31:11 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > one of the most frequent conflicts I see is that two patches add files
> > to OBJS (or one of its other spellings), and there are conflicts because
> > another file has been added.
> > ...
> > Now, obviously these types of conflicts are easy enough to resolve, but
> > it's still annoying. It seems that this would be substantially less
> > often a problem if we just split such lines to one file per
> > line.
>
> We did something similar not too long ago in configure.in (bfa6c5a0c),
> and it seems to have helped. +1
Cool. Any opinion on whether to got for
OBJS = \
dest.o \
fastpath.o \
...
or
OBJS = dest.o \
fastpath.o \
...
I'm mildly inclined to go for the former.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-10-30 06:56:14 | Re: RFC: split OBJS lines to one object per line |
| Previous Message | lingce.ldm | 2019-10-30 06:27:46 | Re: Problem with synchronous replication |