| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: update ALTER TABLE with ATTACH PARTITION lock mode |
| Date: | 2019-10-28 07:55:46 |
| Message-ID: | 20191028075546.GE1687@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Oct 27, 2019 at 07:12:07PM -0500, Justin Pryzby wrote:
> commit #898e5e32 (Allow ATTACH PARTITION with only ShareUpdateExclusiveLock)
> updates ddl.sgml but not alter_table.sgml, which only says:
>
> https://www.postgresql.org/docs/12/release-12.html
> |An ACCESS EXCLUSIVE lock is held unless explicitly noted.
+ <para>
+ Attaching a partition acquires a <literal>SHARE UPDATE EXCLUSIVE</literal>
+ lock on the partitioned table, in addition to an
+ <literal>ACCESS EXCLUSIVE</literal> lock on the partition.
+ </para>
Updating the docs of ALTER TABLE sounds like a good idea. This
sentence looks fine to me. Perhaps others have suggestions?
> Find attached patch, which also improve language in several related places.
Not sure that these are actually improvements.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | k.jamison@fujitsu.com | 2019-10-28 08:13:19 | [Patch] Optimize dropping of relation buffers using dlist |
| Previous Message | Fujii Masao | 2019-10-28 07:53:23 | Re: pgbench - extend initialization phase control |