update ALTER TABLE with ATTACH PARTITION lock mode

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: update ALTER TABLE with ATTACH PARTITION lock mode
Date: 2019-10-28 00:12:07
Message-ID: 20191028001207.GB23808@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

commit #898e5e32 (Allow ATTACH PARTITION with only ShareUpdateExclusiveLock)
updates ddl.sgml but not alter_table.sgml, which only says:

https://www.postgresql.org/docs/12/release-12.html
|An ACCESS EXCLUSIVE lock is held unless explicitly noted.

Find attached patch, which also improve language in several related places.

"Without such a constraint": SUCH could refer to either of the constraints..

"because it is no longer necessary.": In our use case, we prefer to keep the
redundant constraint, to avoid having to add it back if we detach/reattach
again in the future..

Attachment Content-Type Size
v1-0001-Mention-reduced-locking-strength-of-ATTACH-PARTIT.patch text/x-diff 1.0 KB
v1-0002-Tweak-language-for-ATTACH-PARTITION-docs.patch text/x-diff 4.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Smith, Peter 2019-10-28 00:30:11 RE: Proposal: Add more compile-time asserts to expose inconsistencies.
Previous Message Alexander Korotkov 2019-10-27 19:03:48 Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock(PG10.7)