Re: Missing error_context_stack = NULL in AutoVacWorkerMain()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ashwin Agrawal <aagrawal(at)pivotal(dot)io>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Paul Guo <paulguo(at)gmail(dot)com>
Subject: Re: Missing error_context_stack = NULL in AutoVacWorkerMain()
Date: 2019-10-21 04:22:21
Message-ID: 20191021042221.GI1542@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 18, 2019 at 05:55:32PM -0700, Ashwin Agrawal wrote:
> I am not sure if this causes any potential problems or not, but for
> consistency of code seems we are missing below. All other places in code
> where sigsetjmp() exists for top level handling has error_context_stack set
> to NULL.

Resetting error_context_stack prevents calling any callbacks which may
be set. These would not be much useful in this context anyway, and
visibly that's actually not an issue with the autovacuum code so far
(I don't recall seeing a custom callback setup in this area, but I may
have missed something). So fixing it would be a good thing actually,
on HEAD.

Any thoughts from others?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-10-21 04:33:08 Re: Remove obsolete options for createuser
Previous Message Tom Lane 2019-10-21 03:22:21 Re: Ordering of header file inclusion