| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Comment fix of config_default.pl |
| Date: | 2019-07-12 04:01:13 |
| Message-ID: | 20190712040113.GD2149@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote:
> In src/tools/msvc/config_default.pl, parameter "perl" requires a
> path string, not a bool differently from that of configure
> script. --with-python has the same characteristics and the
> comment is suggesting that.
>
> We need to fix --with-perl and --with-uuid the same way.
>
> + uuid => undef, # --with-ossp-uuid=<path>
--with-ossp-uuid is an obsolete spelling. Wouldn't it be better to
replace it with --with-uuid=<path>? That would be a bit inconsistent
with configure which can only take a set of hardcoded names, still
there is little point in keeping an option which would get removed
sooner than later?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-07-12 04:04:24 | Re: Brazil disables DST - 2019b update |
| Previous Message | Robins Tharakan | 2019-07-12 03:42:59 | Brazil disables DST - 2019b update |